[PATCH 15/16] drm/udl: Add register constants for framebuffer scanout addresses

[Javier Martinez Canillas]

On 9/19/22 15:04, Thomas Zimmermann wrote:
> Add register constants for the framebuffer scanout addresses and
> update the related helper functions. No functional changes.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>

[...]

> +	u8 reg20 = (base & 0xff0000) >> 16;
> +	u8 reg21 = (base & 0x00ff00) >> 8;
> +	u8 reg22 = (base & 0x0000ff);
> +

Maybe would be cleaner to use the FIELD_PREP() and GENMASK() macros instead ?

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat