[PATCH 15/16] drm/udl: Add register constants for framebuffer scanout addresses

[Thomas Zimmermann]

Hi

Am 05.10.22 um 00:59 schrieb Javier Martinez Canillas:
> On 9/19/22 15:04, Thomas Zimmermann wrote:
>> Add register constants for the framebuffer scanout addresses and
>> update the related helper functions. No functional changes.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
>> ---
> 
> Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>
> 
> [...]
> 
>> +	u8 reg20 = (base & 0xff0000) >> 16;
>> +	u8 reg21 = (base & 0x00ff00) >> 8;
>> +	u8 reg22 = (base & 0x0000ff);
>> +
> 
> Maybe would be cleaner to use the FIELD_PREP() and GENMASK() macros instead ?
> 

Thank you for reviewing my patchset. I'll update the patch with these 
macros.

Best regards
Thomas


-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20221005/40d500eb/attachment.sig>