[PATCH 01/86] drm/komeda: Direct include headers from drm_print

Thomas Zimmermann tzimmermann at suse.de
Mon Jan 23 07:57:24 UTC 2023


Hi Sam

Am 21.01.23 um 21:07 schrieb Sam Ravnborg via B4 Submission Endpoint:
> From: Sam Ravnborg <sam at ravnborg.org>
> 
> Direct include the headers that otherwise comes indirect from

The grammar in this sentence is slightly off at 'direct include' and 
'headers that [...] comes'.  I'd write 'Directly include header files 
that currently come from drm_print.h.'  Fixes the adverb/adjective issue 
and is fairly neutral whether 'headers' refers to singular or plural.

Unfortunately that issue is in the first 83 patches. :(

Best regards
Thomas

> drm_print.h, because drm_print.h will be reduced to
> include only the minimal set of headers.
> 
> Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> ---
>   drivers/gpu/drm/arm/display/komeda/d71/d71_component.c | 2 ++
>   drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c   | 1 +
>   2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> index 42510fdea27e..875731a8ae90 100644
> --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> @@ -4,6 +4,8 @@
>    * Author: James.Qian.Wang <james.qian.wang at arm.com>
>    *
>    */
> +#include <linux/seq_file.h>
> +
>   #include "d71_dev.h"
>   #include "komeda_kms.h"
>   #include "malidp_io.h"
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c
> index 4b7d94961527..00f5864a0495 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c
> @@ -5,6 +5,7 @@
>    *
>    */
>   #include <linux/of.h>
> +#include <linux/seq_file.h>
>   
>   #include <drm/drm_print.h>
>   
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230123/459932ae/attachment.sig>


More information about the dri-devel mailing list