[PATCH 2/4] DRM: BRIDGE: TFP410: Support basic I2C interface

[Jon Cormier]

On Thu, Jan 26, 2023 at 10:41 AM Krzysztof Kozlowski <
krzysztof.kozlowski at linaro.org> wrote:

> On 25/01/2023 22:09, Jonathan Cormier wrote:
> > From: Michael Williamson <michael.williamson at criticallink.com>
> >
> > The TFP410 driver does not support I2C.  As such, the device remains in
> > Power Down if the I2C is enabled by the bootstrap pins.
> >
> > Add basic support for the I2C interface, and provide support to take
> > the device out of power down when enabled.  Also read the bootstrap mode
> > pins via the CTL_1_MODE register when using the I2C bus.
> >
> > Signed-off-by: Michael Williamson <michael.williamson at criticallink.com>
> > Signed-off-by: Jonathan Cormier <jcormier at criticallink.com>
> > ---
> >  drivers/gpu/drm/bridge/ti-tfp410.c | 95
> +++++++++++++++++++++++++++-----------
> >  1 file changed, 68 insertions(+), 27 deletions(-)
>
> Use subject prefixes matching the subsystem (which you can get for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching).
>
> hint: it is entirely different.
>
It's caps vs non caps so not entirely different.  But it should be
lowercase so I will fix that.   Note there does seem to be some
disagreement between "drm: bridge" and "drm/bridge" in the commits.  The
later appears slightly more often, especially recently so I will go with
that.

>
> >
> > diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c
> b/drivers/gpu/drm/bridge/ti-tfp410.c
> > index b9635abbad16..323a6d9ed188 100644
> > --- a/drivers/gpu/drm/bridge/ti-tfp410.c
> > +++ b/drivers/gpu/drm/bridge/ti-tfp410.c
> > @@ -6,6 +6,7 @@
> >
> >  #include <linux/gpio/consumer.h>
> >  #include <linux/i2c.h>
> > +#include <linux/regmap.h>
> >  #include <linux/media-bus-format.h>
> >  #include <linux/module.h>
> >  #include <linux/of_graph.h>
> > @@ -21,6 +22,20 @@
>
> (...)
>
> >
> >  static void tfp410_i2c_remove(struct i2c_client *client)
> > @@ -408,7 +449,7 @@ MODULE_DEVICE_TABLE(i2c, tfp410_i2c_ids);
> >  static struct i2c_driver tfp410_i2c_driver = {
> >       .driver = {
> >               .name   = "tfp410",
> > -             .of_match_table = of_match_ptr(tfp410_match),
> > +             .of_match_table = tfp410_match,
>
Dropping

>
> This does not look related to the patch.
>
> Best regards,
> Krzysztof
>
>

-- 
Jonathan Cormier
Software Engineer

Voice:  315.425.4045 x222



http://www.CriticalLink.com <http://www.criticallink.com/>
6712 Brooklawn Parkway, Syracuse, NY 13211

<https://www.linkedin.com/company/critical-link-llc>
<https://twitter.com/Critical_Link>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230126/e80deb7e/attachment.htm>