[PATCH] drm/nouveau/volt/gk104: Move assignment outside if condition

sunran001 at 208suo.com sunran001 at 208suo.com
Tue Jul 11 02:31:44 UTC 2023


Fixes the following checkpatch errors:

ERROR: do not use assignment in if condition

Signed-off-by: Ran Sun <sunran001 at 208suo.com>
---
  drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c 
b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
index d1ce4309cfb8..35ab4fa5d18e 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
@@ -113,7 +113,8 @@ gk104_volt_new(struct nvkm_device *device, enum 
nvkm_subdev_type type, int inst,
          volt_func = &gk104_volt_pwm;
      }

-    if (!(volt = kzalloc(sizeof(*volt), GFP_KERNEL)))
+    volt = kzalloc(sizeof(*volt), GFP_KERNEL);
+    if (!volt)
          return -ENOMEM;
      nvkm_volt_ctor(volt_func, device, type, inst, &volt->base);
      *pvolt = &volt->base;
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230711/32d490cd/attachment.htm>


More information about the dri-devel mailing list