[PATCH] drm/nouveau/volt: Move assignment outside if condition
sunran001 at 208suo.com
sunran001 at 208suo.com
Tue Jul 11 02:38:42 UTC 2023
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun <sunran001 at 208suo.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c
index a17a6dd8d3de..d1ae98a42e34 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c
@@ -321,7 +321,8 @@ int
nvkm_volt_new_(const struct nvkm_volt_func *func, struct nvkm_device
*device,
enum nvkm_subdev_type type, int inst, struct nvkm_volt
**pvolt)
{
- if (!(*pvolt = kzalloc(sizeof(**pvolt), GFP_KERNEL)))
+ *pvolt = kzalloc(sizeof(**pvolt), GFP_KERNEL);
+ if (!*pvolt)
return -ENOMEM;
nvkm_volt_ctor(func, device, type, inst, *pvolt);
return 0;
More information about the dri-devel
mailing list