[PATCH] drm/nouveau/devinit: Move assignment outside if condition

sunran001 at 208suo.com sunran001 at 208suo.com
Tue Jul 11 02:45:57 UTC 2023


Fixes the following checkpatch errors:

ERROR: do not use assignment in if condition

Signed-off-by: Ran Sun <sunran001 at 208suo.com>
---
  drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c 
b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c
index 1410befd2285..8185e10efc49 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c
@@ -61,7 +61,8 @@ nv05_devinit_meminit(struct nvkm_devinit *init)
      }

      strap = (nvkm_rd32(device, 0x101000) & 0x0000003c) >> 2;
-    if ((data = bmp_mem_init_table(bios))) {
+    data = bmp_mem_init_table(bios);
+    if (data) {
          ramcfg[0] = nvbios_rd08(bios, data + 2 * strap + 0);
          ramcfg[1] = nvbios_rd08(bios, data + 2 * strap + 1);
      } else {


More information about the dri-devel mailing list