[PATCH] drm/stm: Fix resolution bitmasks

[Philippe CORNU]

On 10/14/22 19:15, Marek Vasut wrote:
> On 10/14/22 17:55, Marek Vasut wrote:
>> On 10/14/22 15:42, Yannick FERTRE wrote:
>>> Hi Marek,
>>
>> Hello Yannick,
>>
>>> The genmask of regsiter SSCR, BPCR & others were setted accordly to 
>>> the chipset stm32f4.
>>
>> So that means:
>> F4 -> 2048x2048 framebuffer
>> H7/MP1 -> 4096x4096 framebuffer
>> ?
> 
> Worse
> 
> F4 is 2048x2048
> F7 is 4096x2048
> MP1 is 4096x4096
> 
> and there is no IDR register on F4/F7 like on MP1, or is there ?
> 
> How else can we tell those LTDC versions apart ?
> 
> 

Dear Marek,
Many thanks for your patch (and sorry for this late reply).
Your patch is good and fixes this ltdc driver source code vs. the 
related reference manual.
imho, it will not be an issue for F4 & F7 series if these bit-fields are 
"bigger" as I am pretty sure stm32 MCUs are not really using such high 
resolutions.
Yannick already replied with his reviewed-by. I add my

Acked-by: Philippe Cornu <philippe.cornu at foss.st.com>

If you agree, I will merge your patch really soon.


Dear Yannick,
You may add to your todo list to double check if there is a need to 
detect stm32 MCUs vs. these bit-field sizes...

Many thanks
Philippe :-)