[PATCH] accel/habanalabs: use kcalloc() instead of kzalloc()

Oded Gabbay ogabbay at kernel.org
Thu Jan 25 10:38:23 UTC 2024


On 22/01/2024 18:45, Gustavo A. R. Silva wrote:
> 
> 
> On 1/20/24 09:10, Erick Archer wrote:
>> As noted in the "Deprecated Interfaces, Language Features, Attributes,
>> and Conventions" documentation [1], size calculations (especially
>> multiplication) should not be performed in memory allocator (or similar)
>> function arguments due to the risk of them overflowing. This could lead
>> to values wrapping around and a smaller allocation being made than the
>> caller was expecting. Using those allocations could lead to linear
>> overflows of heap memory and other misbehaviors.
>>
>> So, use the purpose specific kcalloc() function instead of the argument
>> size * count in the kzalloc() function.
>>
>> Link: 
>> https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [1]
>> Link: https://github.com/KSPP/linux/issues/162
>>
>> Signed-off-by: Erick Archer <erick.archer at gmx.com>
> 
> Reviewed-by: Gustavo A. R. Silva <gustavoars at kernel.org>
> 
> Thanks!
Applied to -next.
Thanks,
Oded


More information about the dri-devel mailing list