[PATCH] drm/msm: Fix gen_header.py for python earlier than v3.9

Jon Hunter jonathanh at nvidia.com
Wed May 8 09:17:51 UTC 2024


Building the kernel with python3 versions earlier than v3.9 fails with ...

 Traceback (most recent call last):
   File "drivers/gpu/drm/msm/registers/gen_header.py", line 970, in <module>
     main()
   File "drivers/gpu/drm/msm/registers/gen_header.py", line 951, in main
     parser.add_argument('--validate', action=argparse.BooleanOptionalAction)
 AttributeError: module 'argparse' has no attribute 'BooleanOptionalAction'

The argparse attribute 'BooleanOptionalAction' is only supported for
python v3.9 and later. Fix support for earlier python3 versions by
explicitly defining '--validate' and '--no-validate' arguments.

Signed-off-by: Jon Hunter <jonathanh at nvidia.com>
---
 drivers/gpu/drm/msm/registers/gen_header.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/registers/gen_header.py b/drivers/gpu/drm/msm/registers/gen_header.py
index fc3bfdc991d2..64f67d2e3f1c 100644
--- a/drivers/gpu/drm/msm/registers/gen_header.py
+++ b/drivers/gpu/drm/msm/registers/gen_header.py
@@ -948,7 +948,8 @@ def main():
 	parser = argparse.ArgumentParser()
 	parser.add_argument('--rnn', type=str, required=True)
 	parser.add_argument('--xml', type=str, required=True)
-	parser.add_argument('--validate', action=argparse.BooleanOptionalAction)
+	parser.add_argument('--validate', dest='validate', action='store_true')
+	parser.add_argument('--no-validate', dest='validate', action='store_false')
 
 	subparsers = parser.add_subparsers()
 	subparsers.required = True
-- 
2.34.1



More information about the dri-devel mailing list