[PATCH] drm/msm: Fix gen_header.py for python earlier than v3.9
Abhinav Kumar
quic_abhinavk at quicinc.com
Wed May 8 16:46:04 UTC 2024
On 5/8/2024 2:17 AM, Jon Hunter wrote:
> Building the kernel with python3 versions earlier than v3.9 fails with ...
>
> Traceback (most recent call last):
> File "drivers/gpu/drm/msm/registers/gen_header.py", line 970, in <module>
> main()
> File "drivers/gpu/drm/msm/registers/gen_header.py", line 951, in main
> parser.add_argument('--validate', action=argparse.BooleanOptionalAction)
> AttributeError: module 'argparse' has no attribute 'BooleanOptionalAction'
>
> The argparse attribute 'BooleanOptionalAction' is only supported for
> python v3.9 and later. Fix support for earlier python3 versions by
> explicitly defining '--validate' and '--no-validate' arguments.
>
> Signed-off-by: Jon Hunter <jonathanh at nvidia.com>
> ---
> drivers/gpu/drm/msm/registers/gen_header.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Thanks for your patch, I had sent something similar y'day.
If you are alright with https://patchwork.freedesktop.org/patch/593057/,
we can use that one.
> diff --git a/drivers/gpu/drm/msm/registers/gen_header.py b/drivers/gpu/drm/msm/registers/gen_header.py
> index fc3bfdc991d2..64f67d2e3f1c 100644
> --- a/drivers/gpu/drm/msm/registers/gen_header.py
> +++ b/drivers/gpu/drm/msm/registers/gen_header.py
> @@ -948,7 +948,8 @@ def main():
> parser = argparse.ArgumentParser()
> parser.add_argument('--rnn', type=str, required=True)
> parser.add_argument('--xml', type=str, required=True)
> - parser.add_argument('--validate', action=argparse.BooleanOptionalAction)
> + parser.add_argument('--validate', dest='validate', action='store_true')
> + parser.add_argument('--no-validate', dest='validate', action='store_false')
>
> subparsers = parser.add_subparsers()
> subparsers.required = True
More information about the dri-devel
mailing list