[PATCH RESEND v9 1/2] drm/atomic: Let drivers decide which planes to async flip

Christopher Snowhill chris at kode54.net
Tue Nov 5 10:15:03 UTC 2024


On Mon Nov 4, 2024 at 12:52 PM PST, André Almeida wrote:
> Hi Christopher,
>
> Em 03/11/2024 03:36, Christopher Snowhill escreveu:
> > On Fri Nov 1, 2024 at 11:23 AM PDT, André Almeida wrote:
> >> Currently, DRM atomic uAPI allows only primary planes to be flipped
> >> asynchronously. However, each driver might be able to perform async
> >> flips in other different plane types. To enable drivers to set their own
> >> restrictions on which type of plane they can or cannot flip, use the
> >> existing atomic_async_check() from struct drm_plane_helper_funcs to
> >> enhance this flexibility, thus allowing different plane types to be able
> >> to do async flips as well.
> >>
> >> In order to prevent regressions and such, we keep the current policy: we
> >> skip the driver check for the primary plane, because it is always
> >> allowed to do async flips on it.
> >>
> >> Signed-off-by: André Almeida <andrealmeid at igalia.com>
> > 
> > Should I do a R-b too? 
>
> If you can review the code, it's always really appreciated.

I mean, I did review your changes, they looked good to me. I just didn't
know the protocol for reporting review in addition to testing.

>
> > The changes looked sound enough for me to feel
> > like testing it as well. Tested Borderlands Game of the Year Enhanced on
> > my RX 7700 XT at maximum settings at 1080p165, and the tearing support in
> > labwc allowed it to reach over 700fps. No problems from the hardware
> > cursor.
>
> Thanks for testing and reporting!
>
> > 
> > Tested-by: Christopher Snowhill <chris at kode54.net>
> > 



More information about the dri-devel mailing list