[PATCH 08/21] dt-bindings: gpu: img: Add BXS-4-64 devicetree bindings

Conor Dooley conor at kernel.org
Wed Nov 6 18:33:34 UTC 2024


On Wed, Nov 06, 2024 at 10:18:10AM +0000, Matt Coster wrote:
> On 05/11/2024 18:03, Conor Dooley wrote:
> > On Tue, Nov 05, 2024 at 03:58:14PM +0000, Matt Coster wrote:
> >> +    / {
> >> +        #address-cells = <2>;
> >> +        #size-cells = <2>;
> >> +        interrupt-controller;
> >> +        #interrupt-cells = <3>;
> >> +
> >> +        gpu at 4e20000000 {
> >> +            compatible = "ti,j721s2-gpu", "img,img-bxs-4-64", "img,img-rogue";
> >> +            reg = /bits/ 64 <0x4e2000 0000 0x80000>;
> > 
> > Can you format this normally please? Drop the #address/size-cells down
> > to 1 if you're against having 0x0s.
> 
> Sure. I thought /bits/ was the "new" way of doing things, but I'm not
> really bothered either way.

Maybe in other cases, I've never seen it for reg. The dts coding style
examples even have 0x0s in them. For other properties, sure this might
be the "new" way of doing it but not for reg, probably in part because
it makes it difficult to see if the number matches the number of cells
in #address/size-cells.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20241106/6ba36379/attachment.sig>


More information about the dri-devel mailing list