[PATCH 5/6] drm/bridge: dw-hdmi-cec: Switch to SYSTEM_SLEEP_PM_OPS()

[neil.armstrong at linaro.org]

On 27/06/2024 01:07, Fabio Estevam wrote:
> From: Fabio Estevam <festevam at denx.de>
> 
> Replace SET_SYSTEM_SLEEP_PM_OPS with its modern SYSTEM_SLEEP_PM_OPS()
> alternative.
> 
> The combined usage of pm_ptr() and SYSTEM_SLEEP_PM_OPS()
> allows the compiler to evaluate if the runtime suspend/resume() functions
> are used at build time or are simply dead code.
> 
> This allows removing the __maybe_unused notation from the runtime
> suspend/resume() functions.
> 
> Signed-off-by: Fabio Estevam <festevam at denx.de>
> ---
>   drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> index 673661160e54..d4614de1ae1e 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> @@ -312,7 +312,7 @@ static void dw_hdmi_cec_remove(struct platform_device *pdev)
>   	cec_unregister_adapter(cec->adap);
>   }
>   
> -static int __maybe_unused dw_hdmi_cec_resume(struct device *dev)
> +static int dw_hdmi_cec_resume(struct device *dev)
>   {
>   	struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
>   
> @@ -328,7 +328,7 @@ static int __maybe_unused dw_hdmi_cec_resume(struct device *dev)
>   	return 0;
>   }
>   
> -static int __maybe_unused dw_hdmi_cec_suspend(struct device *dev)
> +static int dw_hdmi_cec_suspend(struct device *dev)
>   {
>   	struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
>   
> @@ -341,7 +341,7 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct device *dev)
>   }
>   
>   static const struct dev_pm_ops dw_hdmi_cec_pm = {
> -	SET_SYSTEM_SLEEP_PM_OPS(dw_hdmi_cec_suspend, dw_hdmi_cec_resume)
> +	SYSTEM_SLEEP_PM_OPS(dw_hdmi_cec_suspend, dw_hdmi_cec_resume)
>   };
>   
>   static struct platform_driver dw_hdmi_cec_driver = {
> @@ -349,7 +349,7 @@ static struct platform_driver dw_hdmi_cec_driver = {
>   	.remove_new = dw_hdmi_cec_remove,
>   	.driver = {
>   		.name = "dw-hdmi-cec",
> -		.pm = &dw_hdmi_cec_pm,
> +		.pm = pm_ptr(&dw_hdmi_cec_pm),
>   	},
>   };
>   module_platform_driver(dw_hdmi_cec_driver);

Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>