[PATCH 6/6] drm/bridge: imx8qxp-ldb: Switch to RUNTIME_PM_OPS()

[neil.armstrong at linaro.org]

On 27/06/2024 01:07, Fabio Estevam wrote:
> From: Fabio Estevam <festevam at denx.de>
> 
> Replace SET_RUNTIME_PM_OPS with its modern RUNTIME_PM_OPS() alternative.
> 
> The combined usage of pm_ptr() and RUNTIME_PM_OPS()
> allows the compiler to evaluate if the runtime suspend/resume() functions
> are used at build time or are simply dead code.
> 
> This allows removing the __maybe_unused notation from the runtime
> suspend/resume() functions.
> 
> Signed-off-by: Fabio Estevam <festevam at denx.de>
> ---
>   drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c | 9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c b/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c
> index 7984da9c0a35..b33011f397f0 100644
> --- a/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c
> +++ b/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c
> @@ -678,12 +678,12 @@ static void imx8qxp_ldb_remove(struct platform_device *pdev)
>   	pm_runtime_disable(&pdev->dev);
>   }
>   
> -static int __maybe_unused imx8qxp_ldb_runtime_suspend(struct device *dev)
> +static int imx8qxp_ldb_runtime_suspend(struct device *dev)
>   {
>   	return 0;
>   }
>   
> -static int __maybe_unused imx8qxp_ldb_runtime_resume(struct device *dev)
> +static int imx8qxp_ldb_runtime_resume(struct device *dev)
>   {
>   	struct imx8qxp_ldb *imx8qxp_ldb = dev_get_drvdata(dev);
>   	struct ldb *ldb = &imx8qxp_ldb->base;
> @@ -695,8 +695,7 @@ static int __maybe_unused imx8qxp_ldb_runtime_resume(struct device *dev)
>   }
>   
>   static const struct dev_pm_ops imx8qxp_ldb_pm_ops = {
> -	SET_RUNTIME_PM_OPS(imx8qxp_ldb_runtime_suspend,
> -			   imx8qxp_ldb_runtime_resume, NULL)
> +	RUNTIME_PM_OPS(imx8qxp_ldb_runtime_suspend, imx8qxp_ldb_runtime_resume, NULL)
>   };
>   
>   static const struct of_device_id imx8qxp_ldb_dt_ids[] = {
> @@ -709,7 +708,7 @@ static struct platform_driver imx8qxp_ldb_driver = {
>   	.probe	= imx8qxp_ldb_probe,
>   	.remove_new = imx8qxp_ldb_remove,
>   	.driver	= {
> -		.pm = &imx8qxp_ldb_pm_ops,
> +		.pm = pm_ptr(&imx8qxp_ldb_pm_ops),
>   		.name = DRIVER_NAME,
>   		.of_match_table = imx8qxp_ldb_dt_ids,
>   	},

Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>