[PATCH 3/7] drm/writeback: remove pointless enable_signaling implementation

Simona Vetter simona.vetter at ffwll.ch
Tue Sep 24 09:47:25 UTC 2024


On Wed, Sep 11, 2024 at 10:58:59AM +0200, Christian König wrote:
> Just returning true here is a no-op, remove the optional callback.
> 
> Signed-off-by: Christian König <christian.koenig at amd.com>

Patches 1-3:

Reviewed-by: Simona Vetter <simona.vetter at ffwll.ch>

> ---
>  drivers/gpu/drm/drm_writeback.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c
> index a031c335bdb9..33a3c98a962d 100644
> --- a/drivers/gpu/drm/drm_writeback.c
> +++ b/drivers/gpu/drm/drm_writeback.c
> @@ -100,15 +100,9 @@ drm_writeback_fence_get_timeline_name(struct dma_fence *fence)
>  	return wb_connector->timeline_name;
>  }
>  
> -static bool drm_writeback_fence_enable_signaling(struct dma_fence *fence)
> -{
> -	return true;
> -}
> -
>  static const struct dma_fence_ops drm_writeback_fence_ops = {
>  	.get_driver_name = drm_writeback_fence_get_driver_name,
>  	.get_timeline_name = drm_writeback_fence_get_timeline_name,
> -	.enable_signaling = drm_writeback_fence_enable_signaling,
>  };
>  
>  static int create_writeback_properties(struct drm_device *dev)
> -- 
> 2.34.1
> 

-- 
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list