[PATCH 06/10] drm/gem-framebuffer: Test for imported buffers with drm_gem_is_imported()

Anusha Srivatsa asrivats at redhat.com
Fri Feb 28 16:17:06 UTC 2025


Reviewed-by: Anusha Srivatsa <asrivats at redhat.com>

On Wed, Feb 26, 2025 at 12:28 PM Thomas Zimmermann <tzimmermann at suse.de>
wrote:

> Instead of testing import_attach for imported GEM buffers, invoke
> drm_gem_is_imported() to do the test.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> ---
>  drivers/gpu/drm/drm_gem_framebuffer_helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> index 185534f56bab..2bf606ba24cd 100644
> --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> @@ -429,7 +429,7 @@ static void __drm_gem_fb_end_cpu_access(struct
> drm_framebuffer *fb, enum dma_dat
>                 if (!obj)
>                         continue;
>                 import_attach = obj->import_attach;
> -               if (!import_attach)
> +               if (!drm_gem_is_imported(obj))
>                         continue;
>                 ret = dma_buf_end_cpu_access(import_attach->dmabuf, dir);
>                 if (ret)
> @@ -466,7 +466,7 @@ int drm_gem_fb_begin_cpu_access(struct drm_framebuffer
> *fb, enum dma_data_direct
>                         goto err___drm_gem_fb_end_cpu_access;
>                 }
>                 import_attach = obj->import_attach;
> -               if (!import_attach)
> +               if (!drm_gem_is_imported(obj))
>                         continue;
>                 ret = dma_buf_begin_cpu_access(import_attach->dmabuf, dir);
>                 if (ret)
> --
> 2.48.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20250228/50c5c646/attachment.htm>


More information about the dri-devel mailing list