[PATCH v6 1/4] drm: Create mipi_dsi_dual* macros

[Doug Anderson]

Hi,

On Mon, Jul 21, 2025 at 6:53 PM Brigham Campbell <me at brighamcampbell.com> wrote:
>
> Create mipi_dsi_dual, mipi_dsi_dual_dcs_write_seq_multi, and
> mipi_dsi_dual_generic_write_seq_multi macros for panels which are driven
> by two parallel serial interfaces. This allows for the reduction of code
> duplication in drivers for these panels.
>
> Remove mipi_dsi_dual_dcs_write_seq_multi definition from
> panel-novatek-nt36523.c to avoid the duplicate definition. Make novatek
> driver pass mipi_dsi_context struct as a pointer.
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov at oss.qualcomm.com>
> Signed-off-by: Brigham Campbell <me at brighamcampbell.com>
> ---
>  drivers/gpu/drm/drm_mipi_dsi.c                |  48 ++
>  drivers/gpu/drm/panel/panel-novatek-nt36523.c | 804 +++++++++---------
>  include/drm/drm_mipi_dsi.h                    |  95 +++
>  3 files changed, 541 insertions(+), 406 deletions(-)

Just because I was curious and wanted to confirm my claim that this
would result in a nice space savings for novatek, I ran bloat-o-meter
on the novatek module comparing before and after your patch:

add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-8754 (-8754)
Function                                     old     new   delta
elish_csot_init_sequence.d                   758     379    -379
elish_boe_init_sequence.d                    846     423    -423
elish_csot_init_sequence                    9136    5380   -3756
elish_boe_init_sequence                    10192    5996   -4196
Total: Before=33880, After=25126, chg -25.84%

So the new way of defining mipi_dsi_dual_dcs_write_seq_multi() did
indeed give a pretty sweet space savings! :-)

This patch looks good to me now. Thanks for putting up with all my
requests. I know this is a lot bigger than you thought it would be
when you posted your first patch, but I appreciate you sticking with
it!

Reviewed-by: Douglas Anderson <dianders at chromium.org>

My plan would be to give this series another week on the list. If
there is no additional feedback then I'll plan to land it.


-Doug