[PATCH v6 1/4] drm: Create mipi_dsi_dual* macros

Brigham Campbell me at brighamcampbell.com
Wed Jul 23 15:10:26 UTC 2025


On Tue Jul 22, 2025 at 10:20 AM MDT, Doug Anderson wrote:
> On Mon, Jul 21, 2025 at 6:53 PM Brigham Campbell <me at brighamcampbell.com> wrote:
> add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-8754 (-8754)
> Function                                     old     new   delta
> elish_csot_init_sequence.d                   758     379    -379
> elish_boe_init_sequence.d                    846     423    -423
> elish_csot_init_sequence                    9136    5380   -3756
> elish_boe_init_sequence                    10192    5996   -4196
> Total: Before=33880, After=25126, chg -25.84%
>
> So the new way of defining mipi_dsi_dual_dcs_write_seq_multi() did
> indeed give a pretty sweet space savings! :-)

Interesting! With as much as I've heard about compiler optimizations,
I'm kind of surprised that the compiler didn't do a better job before
redefining mipi_dsi_dual_dcs_write_seq_multi(). It's nice to know what
to expect when the rubber hits the proverbial road.

> This patch looks good to me now. Thanks for putting up with all my
> requests. I know this is a lot bigger than you thought it would be
> when you posted your first patch, but I appreciate you sticking with
> it!
>
> Reviewed-by: Douglas Anderson <dianders at chromium.org>
>
> My plan would be to give this series another week on the list. If
> there is no additional feedback then I'll plan to land it.

Thanks, Doug. I appreciate your patient suggestions. Waiting another
week for any additional comments or suggestions sounds good to me!
Thanks for letting me know.

Brigham


More information about the dri-devel mailing list