[PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

[Shengyu Qu]

Thanks, I mistook about the MPO document. Maybe we should also disable 
colorop on the background plane of the cursor plane? So that compositors 
would do sw color convertion on both cursor plane and background plane, 
which should keep cursor display correctly.

在 2025/4/1 0:34, Alex Hung 写道:
> 
> 
> On 3/31/25 10:31, Shengyu Qu wrote:
>> Sorry for vague expression. I mean that I think we shouldn't register 
>> DRM_PLANE_TYPE_CURSOR in the driver, as we don't have actual hardware 
>> support.
> 
> This is not true. AMD has hardware cursor support.
> 
>>
>> 在 2025/4/1 0:26, Alex Hung 写道:
>>>
>>>
>>> On 3/31/25 10:12, Shengyu Qu wrote:
>>>> So currently we have to hope the compositor won't use 
>>>> DRM_PLANE_TYPE_CURSOR planes at all.... Why do we still register 
>>>> DRM_PLANE_TYPE_CURSOR in the driver?
>>>
>>> I am not sure what your question is. A compositor can choose or skip 
>>> any hardware features, but this discussion is out of the scope.
>>>
>>>>
>>>> 在 2025/4/1 0:06, Alex Hung 写道:
>>>>>
>>>>>
>>>>> On 3/31/25 09:43, Shengyu Qu wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Thanks for reply. So currently we have to apply color conversion 
>>>>>> on the background plane of the cursor to do some color space 
>>>>>> conversion. What would happen if cursor and background plane needs 
>>>>>> different conversion config? Or we just give the cursor a 
>>>>>> dedicated plane?
>>>>>
>>>>> This scenario is not supported on AMD hardware, but software 
>>>>> cursors on other plane types won't be affected.
>>>>>
>>>>>>
>>>>>> Best regards,
>>>>>> Shengyu
>>>>>>
>>>>>> 在 2025/3/31 22:28, Alex Hung 写道:
>>>>>>>
>>>>>>>
>>>>>>> On 3/30/25 06:59, Shengyu Qu wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Do we really need to disable cursor plane color pipeline 
>>>>>>>> support? I don't think we need to disable that if it is 
>>>>>>>> supported, since there might be some user-defined colored cursor 
>>>>>>>> icon.
>>>>>>>
>>>>>>> This patch applies to AMD hardware only: https:// 
>>>>>>> elixir.bootlin.com/ linux/v6.13/source/Documentation/gpu/amdgpu/ 
>>>>>>> display/mpo- overview.rst#L101
>>>>>>>
>>>>>>>>
>>>>>>>> Best regards,
>>>>>>>> Shengyu
>>>>>>>>
>>>>>>>> For some unknown reason, seems my mail is not shown in the mail 
>>>>>>>> list archive, so I resent it.
>>>>>>>>
>>>>>>>> 在 2025/3/27 7:47, Alex Hung 写道:
>>>>>>>>> cursor plane does not need to have color pipeline.
>>>>>>>>>
>>>>>>>>> Signed-off-by: Alex Hung <alex.hung at amd.com>
>>>>>>>>> ---
>>>>>>>>> v7:
>>>>>>>>>   - Add a commit messages
>>>>>>>>>
>>>>>>>>>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 +++
>>>>>>>>>   1 file changed, 3 insertions(+)
>>>>>>>>>
>>>>>>>>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/ 
>>>>>>>>> amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/ 
>>>>>>>>> amdgpu_dm_plane.c
>>>>>>>>> index 9632b8b73e7e..b5b9b0b5da63 100644
>>>>>>>>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
>>>>>>>>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
>>>>>>>>> @@ -1792,6 +1792,9 @@ dm_plane_init_colorops(struct drm_plane 
>>>>>>>>> *plane)
>>>>>>>>>       struct drm_prop_enum_list pipelines[MAX_COLOR_PIPELINES];
>>>>>>>>>       int len = 0;
>>>>>>>>> +    if (plane->type == DRM_PLANE_TYPE_CURSOR)
>>>>>>>>> +        return 0;
>>>>>>>>> +
>>>>>>>>>       /* Create COLOR_PIPELINE property and attach */
>>>>>>>>>       drm_plane_create_color_pipeline_property(plane, 
>>>>>>>>> pipelines, len);
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE3520CC91929C8E7.asc
Type: application/pgp-keys
Size: 6868 bytes
Desc: OpenPGP public key
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20250401/5ab2067a/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20250401/5ab2067a/attachment-0001.sig>