[PATCH] etnaviv: Generate new sin/cos instructions on GC3000

Christian Gmeiner christian.gmeiner at gmail.com
Tue Jan 31 07:58:20 UTC 2017


Hi

2017-01-31 8:53 GMT+01:00 Wladimir <laanwj at gmail.com>:
>>
>> whats with the other review comments? Please have a look at them and
>> send a new version of this patch. The
>> current version has too many changes which are not related to sin/cos
>> for GC3000 - sorry.
>>
>
> I'll have a look at it, but to be honest I think we're both too busy
> to bounce patches back and forward indefinitely because of a few
> comment-related changes.
>
> Wladimir

If its okay for you I will do the changes for the patch and push it. I
really want to
have high quality commits like done in other projects. I am not a big
fan of putting unrelated changes into patches as it feels bad and
looks wired when
looking at the history or doing a bisect.

greets
--
Christian Gmeiner, MSc

https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner


More information about the etnaviv mailing list