[PATCH] etnaviv: Generate new sin/cos instructions on GC3000

Wladimir laanwj at gmail.com
Tue Jan 31 08:05:24 UTC 2017


On Tue, Jan 31, 2017 at 8:58 AM, Christian Gmeiner
<christian.gmeiner at gmail.com> wrote:
> If its okay for you I will do the changes for the patch and push it. I
> really want to
> have high quality commits like done in other projects. I am not a big
> fan of putting unrelated changes into patches as it feels bad and
> looks wired when
> looking at the history or doing a bisect.

I understand that, but for me the most important is driver quality
from perspective of the end-user. Generating the proper instructions
for Sin/Cos, as well as the SE CLIP patch are really important for
rendering on affected platforms.

There's only so many hours in a day so we have to pick our fights a bit.

If you want to change the comments in my patch, or make the code style
different, or anything, be my guest, all I care about is to keep the
functionality.

Wladimir


More information about the etnaviv mailing list