farstream: fs-rtp-codec-negotiation.c: possible bad if test ?
David Binderman
dcb314 at hotmail.com
Thu Nov 7 22:23:59 CET 2013
Hello there,
I just tried to compile farstream-0.2.3 with gcc compiler flag -Wlogical-op
It said
fs-rtp-codec-negotiation.c:640:11: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]
Source code is
if (ca->codec->id == FS_CODEC_ID_ANY &&
(bp->codec->id>= 0 || bp->codec->id < 128))
Suggest swap || for &&
Regards
David Binderman
More information about the Farstream-devel
mailing list