farstream: fs-rtp-codec-negotiation.c: possible bad if test ?

Olivier Crête olivier.crete at collabora.com
Thu Nov 7 14:09:36 PST 2013


On Thu, 2013-11-07 at 21:23 +0000, David Binderman wrote:
>  fs-rtp-codec-negotiation.c:640:11: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]
> 
> Source code is
> 
>       if (ca->codec->id == FS_CODEC_ID_ANY &&
>           (bp->codec->id>= 0 || bp->codec->id < 128))
> 
> Suggest swap || for &&

Thanks, committed to master !

-- 
Olivier Crête
olivier.crete at collabora.com



More information about the Farstream-devel mailing list