[Fontconfig-bugs] [Bug 71287] size specific design selection support in OS/2 table version 5

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=71287

Behdad Esfahbod <freedesktop at behdad.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |freedesktop at behdad.org

--- Comment #3 from Behdad Esfahbod <freedesktop at behdad.org> ---
Thanks.  Some more feedback:

- Why the renaming in FcConfigEvaluate()?  It takes a large chunk of the patch
unnecessarily,

- In _FcValuePrintFile, perhaps better to print range using () instead of {}?

- I think we want to make the FC_SIZE to be able to accept both double and
range.  I think you've got that already.  As such, please limit
FcDefaultSubstitute changes to use double when a range is not necessary. 
Ideally we shouldn't see any changes to that function whatsoever.  In fact, I
think it would be fine to expect that the query-pattern has a double size, not
a range size.  Think of this as FC_LANG.  The font patterns have a FcLangSet
object for FC_LANG, but query-pattern has a string FC_LANG.

- I'd separate the cache version jump to a separate commit.

- FcCompareSizeRange() should return the minimum distance from one range to
another.  If the two ranges overlap, that's zero.  Otherwise, return the
minimum distance from one range's end to the other's.

- Again, in FcNameParse, keep thee AddDouble as is.  Possibly add a way to
specify a range, but that's not really important at least initially.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/fontconfig-bugs/attachments/20131210/4a1575f7/attachment.html>