[Fontconfig-bugs] [Bug 101889] Make fontconfig cache relocatable

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=101889

--- Comment #52 from Behdad Esfahbod <freedesktop at behdad.org> ---
I reviewed.  While generally looks good, and I'd be fine with this going in, my
major concern is maintainability of this...

1. The copy paste hashmap implementation get annoying.  We should abstract that
away,

2. I think this has threadsafety issues.  No?  Since the lifecycle of what's
put in the hashmaps is forever(ish), it's possible to make it threadsafe using
pointer cmpexch().  Also, isn't the 4099 hash size a bit too large?

3. The maintainability... The whole cache code has become incomprehensible to
me.  I don't understand the code anymore.  Some more abstractions can
definitely make it much more understandable.

4. Would be great to at least have standalone tests for these.  Is it possible
to mount in-process without root privileges?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/fontconfig-bugs/attachments/20171023/21aaf214/attachment.html>