[Fontconfig-bugs] [Bug 106618] Relocated caches not quite working
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Thu May 24 21:08:46 UTC 2018
https://bugs.freedesktop.org/show_bug.cgi?id=106618
--- Comment #25 from Behdad Esfahbod <freedesktop at behdad.org> ---
Comment on attachment 139730
--> https://bugs.freedesktop.org/attachment.cgi?id=139730
Rewrite paths in caches earlier
Review of attachment 139730:
-----------------------------------------------------------------
::: src/fcpat.c
@@ +378,5 @@
> +{
> + /* We use a value to find the cache, instead of the FcPattern object
> + * because the pattern itself may be a cache allocation if we rewrote the path,
> + * so the p may not be in the cached region. */
> + return FcPatternEltValues(&FcPatternElts (p)[0]);
What if pattern is empty. Doesn't this cause invalid memory access?
Also, there's an assumption that cached patterns have at least two items and
FC_FILE is NOT the first one. Document this?
--
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/fontconfig-bugs/attachments/20180524/eb3e1bf2/attachment.html>
More information about the Fontconfig-bugs
mailing list