[Fontconfig] Attitude to patches made by firefly

[Xie Qian]

Hi, there.

Nice to see these Chinese releted patches being filed. But I think rationality of modification need explaining in detail. I've checked the patches briefly, see my comments below. 

 
Xie Qian
 
Open System and Chinese Information Processing Center,
Institute of Software, Chinese Academy of Sciences,
P.O. Box 8718, Beijing 100080, CHINA

----- Original Message ----- 
From: "Funda Wang" <fundawang at linux.net.cn>
To: <fontconfig at freedesktop.org>
Sent: Monday, November 15, 2004 12:42 AM
Subject: [Fontconfig] Attitude to patches made by firefly


> Hello,
> 
> Fontconfig has various problem regards Chinese. A hacker named Firefly
> has done his final patch to 2.2.3, which can be checked here:
> http://firefly.idv.tw/setfont-xft/patches/fontconfig/2.2.3/
> 
> What is the attitude towards those patch?
> * fontconfig-2.2.3-add_extra_option-20041114.patch:
>    added an option to choose whether to use gamma correction. In current situation, Chinese characters are too bright.

As changes is applied to FcBoolDefaults, doesn't this modification affect other font's rendering?

> * fontconfig-2.2.3-alllang-20041114.patch
>    Some asian fonts include fonts more than one language family, i.e. ttc fonts

Considering the Uni-Han problem, no CJK fonts can be acceptable in China mainland, Taiwan, Japan and Korea due to character shape diversity. Exclusive lang tag can be use to match most suitable CJK font. So this is a designed feature.

> * fontconfig-2.2.3-include_CJK_charmaps-20041114.patch
>    Extra big5 table.

I don't know the usage, nothing to comment.

> * fontconfig-2.2.3-multifamily_fakestyle-20041114.patch
>    Compute fake bold and italic style for families do not provide those styles.

I think this is absolutely needed.

> 
> _______________________________________________
> fontconfig mailing list
> fontconfig at freedesktop.org
> http://freedesktop.org/mailman/listinfo/fontconfig
>