[Freedreno] [PATCH v3 0/8] freedreno: a2xx improvements

Rob Clark robdclark at gmail.com
Sat Mar 24 23:37:10 UTC 2018


On Fri, Mar 23, 2018 at 7:21 AM, Wladimir J. van der Laan
<laanwj at gmail.com> wrote:
> While working on a205 support for i.MX51/53, I've also written some patches
> that are not specific to a20x but should apply to the whole a2xx range.
>
> As I'm figuring out how to handle backward compatibility to other a2xx, I
> think it makes sense to send these upstream already to reduce the patch stack.
>
> Changes since v1:
>
> - Split up rnndb patch into a patch that changes formate numeration
>   and one that changes BLEND->BLEND2.
> - fd2_emit emit_texture const correctness.
>
> I checked that there is no Gallium capability to be set for TEXTURE_RECT.
>
> Changes since v2:
> - Tabs/spaces cleanup patch 6,7,8
>

Patchset looks reasonable to me, from a quick look.  Testing a22x
isn't so easy without resurrecting an ancient downstream kernel for
old snadragon devices, so I think it is ok to ignore that.  If the
rnndb bits are merged already, then:

Reviewed-by: Rob Clark <robdclark at gmail.com>

(and if not ping me, I might have overlooked some patches..)


> Wladimir J. van der Laan (8):
>   freedreno: a2xx: Update rnndb header for formats enumeration
>   freedreno: a2xx: Change use of BLEND_ to BLEND2_
>   freedreno: a2xx: Fix fd2_tex_swiz
>   freedreno: a2xx: Prevent crash in emit_texture if view is not set
>   freedreno: a2xx: Support TEXTURE_RECT
>   freedreno: a2xx: Compressed textures support
>   freedreno: a2xx: implement SEQ/SNE instructions
>   freedreno: a2xx: Implement DP2 instruction
>
>  src/gallium/drivers/freedreno/a2xx/a2xx.xml.h     | 33 +++++++---------
>  src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 47 +++++++++++++++++++++--
>  src/gallium/drivers/freedreno/a2xx/fd2_emit.c     | 13 +++++--
>  src/gallium/drivers/freedreno/a2xx/fd2_gmem.c     |  4 +-
>  src/gallium/drivers/freedreno/a2xx/fd2_util.c     | 29 +++++++++-----
>  src/gallium/drivers/freedreno/a2xx/ir-a2xx.c      |  1 +
>  src/gallium/drivers/freedreno/a2xx/ir-a2xx.h      |  1 +
>  7 files changed, 90 insertions(+), 38 deletions(-)
>
> --
> 2.7.4
>


More information about the Freedreno mailing list