[Freedreno] [PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS

[Konrad Dybcio]

On 7.05.2023 21:07, Dmitry Baryshkov wrote:
> Enable ADSP and Modem DSPs on APQ8074 dragonboard. The MSS region
> differs from the one defined in the msm8974, so it overriden locally.
> 
> The modem is specified use mba.mbn instead of mbn.b00 (for the sake of
> similarity with other platforms). This requires a patch for remoteproc
> to be applied [1].
> 
> [1] https://lore.kernel.org/all/20230507172041.2320279-1-dmitry.baryshkov@linaro.org/
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> ---
>  .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> index 6b047c679370..c893afc00eb4 100644
> --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> @@ -4,6 +4,8 @@
>  #include "qcom-pm8841.dtsi"
>  #include "qcom-pm8941.dtsi"
>  
> +/delete-node/ &mpss_region;
> +
>  / {
>  	model = "Qualcomm APQ8074 Dragonboard";
>  	compatible = "qcom,apq8074-dragonboard", "qcom,apq8074";
> @@ -17,6 +19,13 @@ aliases {
>  	chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
> +
> +	reserved-memory {
> +		mpss_region: mpss at ac00000 {
> +			reg = <0x0ac00000 0x2500000>;
> +			no-map;
> +		};
> +	};
>  };
>  
>  &blsp1_uart2 {
> @@ -39,6 +48,25 @@ eeprom: eeprom at 52 {
>  	};
>  };
>  
> +&remoteproc_adsp {
> +	cx-supply = <&pm8841_s2>;
> +
> +	firmware-name = "qcom/apq8074/adsp.mbn";
> +
> +	status = "okay";
> +};
> +
> +&remoteproc_mss {
> +	cx-supply = <&pm8841_s2>;
> +	mss-supply = <&pm8841_s3>;
> +	mx-supply = <&pm8841_s1>;
> +	pll-supply = <&pm8941_l12>;
High time to move this to rpmpd!
I won't object to adding this though, as it obviously works
and is already used on other boards..

> +
> +	firmware-name = "qcom/apq8074/mba.mbn", "qcom/apq8074/modem.mbn";
Could you please keep it one entry per line?

Otherwise,

Reviewed-by: Konrad Dybcio <konrad.dybcio at linaro.org>

Konrad
> +
> +	status = "okay";
> +};
> +
>  &rpm_requests {
>  	regulators-0 {
>  		compatible = "qcom,rpm-pm8841-regulators";