[PATCH 0/3] drm/msm/dp: Fix and utilize TPG with a debugfs

[Marijn Suijten]

On 2024-12-02 12:41:57, Abhinav Kumar wrote:
> DP Test Patten Generator is a very useful tool to debug issues such
> as blank screen or corruption seen on the DP monitor by isolating it
> to whether the corruption is coming from further upstream such as DPU
> OR from the DP controller and below. It was noted in [1] that this API
> is unused. Rather than dropping the API, it should be fixed and used.
> 
> Hence, this series fixes the DP Test Patten Generator API and also utilizes
> it by adding a debugfs for it.
> 
> [1] : https://patchwork.freedesktop.org/patch/623508/?series=141074&rev=1

This all sounds great, but perhaps the "unused function" issue applies to the
DSI TPG from your series at [1] as well.  There, the patch describes where to
insert the function call, but I remember that the contents of that function also
changed over time.

Are you planning to add a debugfs entry, or perhaps entries to configure the
pattern bits for DPU's DSI TPG as well, as suggested in [2]?  Or should someone
else look into it to make it useful again?

[1]: https://lore.kernel.org/linux-arm-msm/1626922232-29105-2-git-send-email-abhinavk@codeaurora.org/
[2]: https://lore.kernel.org/linux-arm-msm/CAA8EJpqjWbEbgn9Sw=Hd8f7pP+NXDeM308jG8HirKjk7QcfOxA@mail.gmail.com/

> 
> To: Rob Clark <robdclark at gmail.com>
> To: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> To: Sean Paul <sean at poorly.run>
> To: Marijn Suijten <marijn.suijten at somainline.org>
> To: David Airlie <airlied at gmail.com>
> To: Simona Vetter <simona at ffwll.ch>
> To: Stephen Boyd <swboyd at chromium.org>
> To: Kuogee Hsieh <quic_khsieh at quicinc.com>
> Cc: linux-arm-msm at vger.kernel.org
> Cc: dri-devel at lists.freedesktop.org
> Cc: freedreno at lists.freedesktop.org
> Cc: linux-kernel at vger.kernel.org
> Cc: Jessica Zhang <quic_jesszhan at quicinc.com>
> 
> Signed-off-by: Abhinav Kumar <quic_abhinavk at quicinc.com>
> ---
> Abhinav Kumar (3):
>       drm/msm/dp: account for widebus in msm_dp_catalog_panel_tpg_enable()
>       drm/msm/dp: do not touch the MMSS_DP_INTF_CONFIG for tpg
>       drm/msm/dp: add a debugfs node for using tpg

Should TPG be capitalized in these titles, as it is an abbreviation with
capitalized words in your description as well?

Thanks!

- Marijn

> 
>  drivers/gpu/drm/msm/dp/dp_catalog.c | 15 +++++++--
>  drivers/gpu/drm/msm/dp/dp_debug.c   | 61 +++++++++++++++++++++++++++++++++++++
>  drivers/gpu/drm/msm/dp/dp_panel.h   |  2 ++
>  3 files changed, 76 insertions(+), 2 deletions(-)
> ---
> base-commit: 798bb342e0416d846cf67f4725a3428f39bfb96b
> change-id: 20241202-tpg-3f7543c036ac
> 
> Best regards,
> -- 
> Abhinav Kumar <quic_abhinavk at quicinc.com>
>