[gstreamer-bugs] [Bug 353475] Improve detection of supported uris on GstURIHandlerInterface

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=353475
 GStreamer | gstreamer (core) | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement




------- Comment #4 from Tim-Philipp Müller  2006-08-31 17:28 UTC -------
The first question is whether we would want to support arbitrary protocols in
gnomevfssrc in the first place, or rather only support
known-to-be-good-and-stable protocols like we do now.

If we add new API for something like this, we might want to consider things
like per-protocol ranks as well (and whether we want to cover that with the
same API or a separate piece of API).


In your patch in gst_uri_handler_uri_is_supported() you do:

 +  g_return_val_if_fail (iface->uri_is_supported != NULL, FALSE);

That doesn't look quite right to me. g_return_val_if_fail() should only be used
to catch programming errors and invalid input and such. If non-implementation
of the uri_is_supported method is acceptable (and it is, since it is an
optional addition), the function must not throw a warning and just return FALSE
as the documentation suggests (or ideally fall back on going through the
protocols array and decide based on that).


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.