[gstreamer-bugs] [Bug 353475] Improve detection of supported uris on GstURIHandlerInterface

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=353475
 GStreamer | gstreamer (core) | Ver: HEAD CVS





------- Comment #5 from Andre Moreira Magalhaes  2006-08-31 17:41 UTC -------
(In reply to comment #4)
> The first question is whether we would want to support arbitrary protocols in
> gnomevfssrc in the first place, or rather only support
> known-to-be-good-and-stable protocols like we do now.
This is up to you guys. I personally think this is an interesting adition, but
i am biased :).

> If we add new API for something like this, we might want to consider things
> like per-protocol ranks as well 
I quite don't understand this, could you elaborate a little more. 

> (and whether we want to cover that with the same API 
> or a separate piece of API).
I believe the same API for now is enough, but we can think of a new API later
if needed.

> In your patch in gst_uri_handler_uri_is_supported() you do:
> 
>  +  g_return_val_if_fail (iface->uri_is_supported != NULL, FALSE);
> 
> That doesn't look quite right to me. g_return_val_if_fail() should only be used
> to catch programming errors and invalid input and such. If non-implementation
> of the uri_is_supported method is acceptable (and it is, since it is an
> optional addition), the function must not throw a warning and just return FALSE
> as the documentation suggests (or ideally fall back on going through the
> protocols array and decide based on that).
Agreed, i will fix this. I just don't know what is best, to fallback on the
protocols array or return FALSE. I will just return FALSE for now, but i can
change it later if needed.

BR
Andrunko 


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.