[gstreamer-bugs] [Bug 340362] [PATCH] new plugin - hardlimiter

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=340362
 GStreamer | gst-plugins-bad | Ver: HEAD CVS





------- Comment #9 from Tim-Philipp Müller  2006-05-12 12:05 UTC -------
> - GST_BOILERPLATE_FULL was inserted by the template tool from gst-template
> package. I thought all elements require this one.

Apologies, I missed that that is from template :) (It's ugly nevertheless IMHO)


> - transform_ip() indeed should return GST_FLOW_OK if buffer is unwritable
> (checking if in passthrough mode).
> - strange, that the element did not do anything for you. It shouldn't
> passthrough on same caps and works for me here.

No idea about these, have to investigate.


> - yes, hardlimiting sounds like clipping/distortion. And sounds horrible but
> still better than soundcard clipping. 

I was looking at the wave curve in a sound editor, not listening to it :)


> However, I'm currently writing a more general
> compressor unit that should provide a better sounding solution.

Great!


> - GstController stuff also was sitting in the template. I thought it's
> generally a good idea to have controlled elements. Aren't they especially
> useful for NLE apps? Correct me, if I'm wrong.

No, you're absolutely right. I thought the GstController stuff was supposed to
serve another purpose and got confused.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.