[gstreamer-bugs] [Bug 343131] [wavpack][PATCH] new wavpackenc element

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=343131
 GStreamer | gst-plugins-bad | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66391|none                        |commented-on
               Flag|                            |
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




------- Comment #4 from Tim-Philipp Müller  2006-05-30 09:55 UTC -------
Cool, nice work, almost ready to go in. Some small nitpicks:

gst_wavpack_enc_sink_set_caps():
 - I don't think you are supposed to unref the input caps - doesn't
   that trigger warnings or valgrind complaints?

gst_wavpack_enc_push_blocks():
 - the last block should probably just be g_assert_not_reached().

gst_wavpack_enc_chain():
 - we've got GST_ROUND_UP_X macros in gstutils.h ;)
 - we also have gst_pad_query_peer_duration() now
 - don't think '1LL' is something understood by all compilers,
   there's a GLib macro for that purpose though.
 - towards the end you gst_object_unref (wavpack_enc) but then
   happily keep accessing it. You should unref it only after
   you don't need it any longer really.


And please tell me wavpack doesn't export functions called 'MD5Update' etc.
without prefixing these? (And if they are not prefixed, are you supposed to use
them?)


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.