[gstreamer-bugs] [Bug 343131] [wavpack][PATCH] new wavpackenc element

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=343131
 GStreamer | gst-plugins-bad | Ver: HEAD CVS





------- Comment #5 from Sebastian Dröge  2006-05-30 10:17 UTC -------
a) yes, that's probably the reason for the warning I sometimes get... but iirc
it didn't disappear after removing the unref()... I'll test when I'm back home
b) right, will be changed
c) for round up that would be GST_ROUND_UP_8 (width) / 8?
d) for 1LL it should be G_GINT64_CONSTANT (1)?
e) right... the unref() will be fixed ;)

for the MD5Update functions, etc... yes they're unfortunately exported but this
will be fixed in future wavpack versions too, the library simply won't include
the MD5 stuff and users of the library must have their own implementation. (it
doesn't make much sense to put it in the library because the MD5 sum is on the
unmodified samples but the library only gets the samples padded to 32 bit, i.e.
modified ones )
I'll include the MD5 implementation with my next patch, all functions prefixed
with _gst_wavpack_enc_*. Is this ok for you?


I also have some other fixes locally, namely the offset and offset end of the
buffers is now set (am I right that the offset would be in samples for audio?
the decoder does this currently) and correction buffers also get timestamp,
duration, offset and offset end.

I'll upload a diff with all this changes when I'm back home... please let me
know if you have any other issues :)

Bye

PS: the decoder is now converted to the "real" API too, was really very easy...
only the parser will need some more work it seems... but should be finished for
the weekend :)


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.