[gstreamer-bugs] [Bug 343131] [wavpack][PATCH] new wavpackenc element

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=343131
 GStreamer | gst-plugins-bad | Ver: HEAD CVS





------- Comment #6 from Tim-Philipp Müller  2006-05-30 10:40 UTC -------
> c) for round up that would be GST_ROUND_UP_8 (width) / 8?

Actually, I misread the code. No need to use the macro here.


> d) for 1LL it should be G_GINT64_CONSTANT (1)?

yes


> I'll include the MD5 implementation with my next patch, all functions
> prefixed with _gst_wavpack_enc_*. Is this ok for you?

Sure. If you ship them with the plugin, the prefix doesn't really matter, it'll
be masked out and not be exported anyway (by the build system) (I think).

> I also have some other fixes locally, namely the offset and offset end of the
> buffers is now set (am I right that the offset would be in samples for audio?
> the decoder does this currently) and correction buffers also get timestamp,
> duration, offset and offset end.

Yes, offset is in samples (per channel, ie. channel-independent, ie. same
amount for mono or stereo for the same duration at the same sample rate). Not
that it hurts, but setting offset/offset_end isn't really necessary or
particularly useful for encoded/compressed data, only timestamp/duration is
(for muxers).


> I'll upload a diff with all this changes when I'm back home... please let me
> know if you have any other issues :)

You probably want to intercept incoming NEWSEGMENT events and just drop them
(and then send your own newsegment event in BYTES format starting from 0 when
you push the header). Otherwise the sink might get confused by multiple
newsegment events in possibly different formats and weird things might happen.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.