[gstreamer-bugs] [Bug 354007] [PLUGIN-MOVE] videocrop should be moved to -good

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Fri Sep 8 03:00:26 PDT 2006


Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=354007
 GStreamer | gst-plugins-good | Ver: HEAD CVS





------- Comment #2 from Michael Smith  2006-09-08 09:59 UTC -------
Code itself looks largely good.

In common with most of the rest of gstreamer's video handling, our inability to
do anything useful with stride makes me cringe.

The handling of odd-offsets in chroma-subsampled planes looks incorrect; we
probably don't care about that enough to fix it right now (it's hard), but we
should document it.

I can't run the valgrind test; I wanted to add a test that cropped to 1x1, and
make sure that ran correctly, but I couldn't. liboil screwing me over...

Tim, if you can add that test, check that it runs successfully, and add
something documenting that odd top or left offsets are handled incorrectly, I'm
happy to sponsor this.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list