[gstreamer-bugs] [Bug 354007] [PLUGIN-MOVE] videocrop should be moved to -good

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=354007
 GStreamer | gst-plugins-good | Ver: HEAD CVS





------- Comment #3 from Tim-Philipp Müller  2006-09-08 17:10 UTC -------
Thanks for the review.

> In common with most of the rest of gstreamer's video handling, our inability to
> do anything useful with stride makes me cringe.

Yeah, don't really see us fixing that in 0.10 though (not in the near future at
least).


> The handling of odd-offsets in chroma-subsampled planes looks incorrect; we
> probably don't care about that enough to fix it right now (it's hard), but we
> should document it.

Documented now.


> I can't run the valgrind test; I wanted to add a test that cropped to 1x1,
> and make sure that ran correctly, but I couldn't. liboil screwing me over...
> 
> Tim, if you can add that test, check that it runs successfully, and add
> something documenting that odd top or left offsets are handled incorrectly,
> I'm happy to sponsor this.

Added test that crops to 1x1 and checks the data matches the expected data for
a small number of formats. Hope that's more or less what you had in mind. If
not, let me know and I'll add more stuff. Runs fine in valgrind here.




2006-09-08  Tim-Philipp Müller  <tim at centricular dot net>

        * configure.ac:
          Bump requirements of -base (videocrop test case needs this).

        * gst/videocrop/gstvideocrop.c:
          Document sloppy handling of subsampled chroma planes if
          left/top cropping is an odd number.

        * tests/check/elements/videocrop.c: (handoff_cb),
        (videocrop_test_cropping_init_context),
        (videocrop_test_cropping_deinit_context),
        (videocrop_test_cropping), (check_1x1_buffer), (GST_START_TEST),
        (videocrop_suite), (main):
          Add another unit test that crops the input to 1x1 (and checks
          that that pixel has the expected values in a number of formats).

2006-09-08  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/videocrop/Makefile.am:
        * gst/videocrop/gstvideocrop.c: (gst_video_crop_class_init),
        (gst_video_crop_transform_packed),
        (gst_video_crop_transform_planar):
          Some quick tests indicate that it doesn't make a great deal
          of sense to use liboil here, at least not for the memcpy()s
          we do, so remove liboil usage until there is clear evidence
          it actually makes a positive difference somewhere.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.