[gstreamer-bugs] [Bug 348085] [PLUGIN-MOVE] move spectrum to good

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=348085
 GStreamer | gst-plugins-bad | Ver: HEAD CVS





------- Comment #5 from Stefan Kost (gstreamer, gtkdoc dev)  2006-09-12 18:17 UTC -------
Why GST_EBUG_OBJECT() this imho ofen just bloats debugs logs. How many
analyzers are you using at the same time. As transform_ip() will be called a
multiple time LOG() seems to be fine.

Regarding overriding the event-func(). When EOS gets emitted, it will be caught
be the app and then the state-change happens. So I don't yet agree that we have
to handle EOS.

regarding GST_SECOND/10 vs. GST_MSECOND*100, maybe you should have a look at
how GST_MSECOND is defined :)

Finally g_realloc(): we don't *want* to copy data we will overwrite :) Lets not
nitpick too much, this is just fine as it is.

I'll do the stop() method for the adapter_clear(). As a side note, theres a
dozen plugins that also clear() on start() (or PAUSED_TO_PLAYING).


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.