[gstreamer-bugs] [Bug 348085] [PLUGIN-MOVE] move spectrum to good

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=348085
 GStreamer | gst-plugins-bad | Ver: HEAD CVS





------- Comment #6 from René Stadler  2006-09-12 19:12 UTC -------
(In reply to comment #5)
> Why GST_EBUG_OBJECT() this imho ofen just bloats debugs logs. How many
> analyzers are you using at the same time. As transform_ip() will be called a
> multiple time LOG() seems to be fine.

This tells us that the message is superfluous and can be omitted anyways.  The
transform function should indeed produce at most 1 message IMHO.

> Regarding overriding the event-func(). When EOS gets emitted, it will be caught
> be the app and then the state-change happens. So I don't yet agree that we have
> to handle EOS.

You don't know that the app takes down the state of the whole pipeline at EOS. 
Can you point out where this is stated as a hard requirement?  I just put
months of work into an element that relies on that behaviour.

> 
> regarding GST_SECOND/10 vs. GST_MSECOND*100, maybe you should have a look at
> how GST_MSECOND is defined :)
> 

It doesn't really matter how it is defined.  Definitions can change.  Never
said the current practice breakes anything and will break anyhow.  Multiplying
is really more clean for obvious reasons, but granted.

> Finally g_realloc(): we don't *want* to copy data we will overwrite :) Lets not
> nitpick too much, this is just fine as it is.
> 

Granted.

> I'll do the stop() method for the adapter_clear(). As a side note, theres a
> dozen plugins that also clear() on start() (or PAUSED_TO_PLAYING).
> 

Have to grant that my argument works both ways.  It's "why bother cleaning up
if we might die anyways" vs. "why keep something around we don't need later
anyways"  or maybe rather "why delay the startup for something we could have
dropped later".  Still makes a bit more sense in stop.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.