[gstreamer-bugs] [Bug 420079] [audioconvert] Uses biased rounding which results in distortions

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=420079

  GStreamer | gst-plugins-base | Ver: HEAD CVS


Jan Schmidt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thaytan at mad.scientist.com




------- Comment #3 from Jan Schmidt  2007-03-19 17:25 UTC -------
when scale == 0 in the else branch, the ">> scale" can be skipped too...

Computing 1 << (scale-1) outside the loop is probably worth it too, as you say.

Also, why the check that tmp > 0 in the comparison? it's a guint32, so it can
never be negative, and 0 itself doesn't seem harmful in the "G_MAXINT32 - tmp <
(1<<(scale-1))" part.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email