[gstreamer-bugs] [Bug 420079] [audioconvert] Uses biased rounding which results in distortions

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=420079

  GStreamer | gst-plugins-base | Ver: HEAD CVS





------- Comment #4 from Sebastian Dröge  2007-03-19 19:25 UTC -------
Well, that tmp > 0 comparison is "necessary"...
For some reason I thought tmp was a gint32. In that case I have to check if
it's greater 0 before doing the "overflow check"... otherwise it will overflow
in the overflow check.

I have a version locally that your two ideas implemented... but I believe I
should add another local variable for that logic that is signed. I have
actually no idea why the result was the same as if the variable was signed ;)

I'll investigate and attach a new patch later...


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email