[gstreamer-bugs] [Bug 420079] [audioconvert] Uses biased rounding which results in distortions

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=420079

  GStreamer | gst-plugins-base | Ver: HEAD CVS


Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84873|0                           |1
        is obsolete|                            |




------- Comment #5 from Sebastian Dröge  2007-03-19 20:23 UTC -------
Created an attachment (id=84909)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=84909&action=view)
audioconvert-rounding.patch

Ok, this is how I planned to do it from the beginning with a signed temporary
variable.

If I do it all on the unsigned tmp how I wanted to do it, it would become hard
to understand and I would need another else if in there as I must check if I'm
below 0x7fffffff (i.e. G_MAXINT32) and would get over 0x7ffffff (i.e. must set
0x7fffffff) and also must check if I could get over 0xffffffff.

Please tell me if I'm missing something here...


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email