[gstreamer-bugs] [Bug 518162] [subparse] handle italic text starting with "/" with MicroDVD subs

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Sat Feb 23 02:03:21 PST 2008


If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=518162

  GStreamer | gst-plugins-base | Ver: 0.10.17

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|t.i.m at zen.co.uk             |gstreamer-
                   |                            |bugs at lists.sourceforge.net
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Summary|Patch for GStreamer to      |[subparse] handle italic
                   |handle italic text starting |text starting with "/" with
                   |with "/" with MicroDVD subs |MicroDVD subs
   Target Milestone|HEAD                        |0.10.18




------- Comment #2 from Tim-Philipp Müller  2008-02-23 10:03 UTC -------
Thanks for the fix, it should work fine in CVS now:

 2008-02-23  Tim-Philipp Müller  <tim at centricular dot net>

        Based on patch by: Tomasz Sałaciński <tsalacinski gmail com>

        * gst/subparse/gstsubparse.c: (parse_mdvdsub):
        * tests/check/elements/subparse.c: (test_microdvd_with_italics),
          (subparse_suite):
          Forward slashes at the beginning and end of a line also signify
          italics (Fixes: #518162).

(I'm not entirely clear whether the forward/end slashes may span multiple lines
though - do they? If so, we currently don't handle that properly).


This: "line = g_strndup(line, strlen(line) - 1);" leaks by the way.


(In reply to comment #1)
> And, additionally, mdvd parser, if won't find number of FPS in the file, like:
> 
> {1}{1}25.000
> 
> it will use 23,976 (it's hardcoded).

It *should* parse the fps from that line, there's even a unit test to make sure
it does. Could you investigate why it fails? 23.976 is only used as fallback
when we don't find a hard-coded framerate.


> IMHO the parser should use the movie's FPS

If no framerate is specified, any framerate is as good as any other really.
microdvd subs without framerate are per definition really pretty much broken,
it's a frame-based format after all :)  Also, the subparse element does not
have access to the framerate of the video either, it would need to be set via a
property by the player etc. etc.


> (for example Totem shows 25.000 FPS and it's working fine). Some movies are
> encoded in 25.000 FPS and there is no information in the subtitle file about
> this. Windows players handle this perfectly, though.

That's mostly just luck then (admittedly the 23.976 fallback is somewhat
unfortunate for european users of course).

I will accept a patch that reads the default framerate from an environment
variable though.



> And, there is something wrong with this line:
>   (snip) 
> Sometimes, after seeking, the subtitles are not shown, even if they are
> supposed to be shown. GStreamer will show the next line and continue to show
> subs properly then, it's only after seeking.

I don't think this is a problem in subparse, it's a problem in the textoverlay
element and has to do with keyframe seeking. I've got a fix for that somewhere
though, I should commit that, thanks for reminding me.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=518162.




More information about the Gstreamer-bugs mailing list