[gstreamer-bugs] [Bug 518162] [subparse] handle italic text starting with "/" with MicroDVD subs

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=518162

  GStreamer | gst-plugins-base | Ver: 0.10.17




------- Comment #3 from Tomasz Sałaciński  2008-02-23 13:07 UTC -------
> (I'm not entirely clear whether the forward/end slashes may span multiple lines
> though - do they? If so, we currently don't handle that properly).

The thing is, that leading slash makes the line italic, trailing slash is not
doing anything, just sometimes subtitle authors are putting / italic text /
into the subs and media players are removing the trailing slash (for ex. polish
media players like SubEdit player).

And, media players are reading the FPS for subtitles from the file and when it
won't succeed, they are loading them from the movie.

Maybe adding a movie_fps float to state structure can resolve the problem?

> I don't think this is a problem in subparse, it's a problem in the textoverlay
> element and has to do with keyframe seeking. I've got a fix for that somewhere
> though, I should commit that, thanks for reminding me.

I agree with you, the code looks perfect to me. Removing it slows down
gstreamer, but fixes this bug.


> It *should* parse the fps from that line, there's even a unit test to make sure
> it does. Could you investigate why it fails? 23.976 is only used as fallback
> when we don't find a hard-coded framerate.

And it does parse the FPS number from this line. It does it perfectly, so IMHO
there is no need to check anything.

Actually, the only thing that will make life much easier, is the current frame.
But I believe it won't be easy to pass the current frame number to subparse...


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=518162.