[gstreamer-bugs] [Bug 533265] [cddabasesrc] Sound Juicer cut a sector when ripping a track

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=533265

  GStreamer | gst-plugins-base | Ver: 0.10.x

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
            Summary|Sound Juicer cut a sector   |[cddabasesrc] Sound Juicer
                   |when ripping a track        |cut a sector when ripping a
                   |                            |track




------- Comment #1 from Tim-Philipp Müller  2008-05-27 19:06 UTC -------
<wtay> the cdda base class seems not to read the last sector, it goes EOS when
curr >= track.end
<wtay> and in add_track track.end must be strictly smaller than the start of
the next track, suggesting the end is included in that track

I think you're right and it should be eos = (cur > end).

The query function also seems to include the last sector in the length:

   num_sectors = end_sector - start_sector + 1;


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=533265.