[gstreamer-bugs] [Bug 576800] gstreamer SPC plugin requires non-portable x86 code

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=576800

  GStreamer | gst-plugins-bad | Ver: git

Michael Pyne changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131402|0                           |1
        is obsolete|                            |




------- Comment #8 from Michael Pyne  2009-08-02 05:43 UTC -------
Created an attachment (id=139717)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=139717&action=view)
Use libgme for SPC playback.

This patch uses libgme (the shared library instead by Game_Music_Emu) for
playback of SPC files.  Note that the libgme 0.5.5 release I mentioned exported
too many headers, only the gme/gme.h file is supposed to be used by client
code, which will be rectified in the next release.

I did forget that someone mentioned that it would be preferable to support both
the old library and libgme so I guess I'll go back and add ifdef's or such. 
But this is what the patch will look like aside from that unless anyone sees
other issues with it.

I've tried to maintain the correct style but I don't have GNU indent and I
wasn't going to install it just to satisfy git so please don't assume your
precommit hooks caught my mistakes. :(

One final point: libgme supports more systems than just SNES.  I know that this
plugin collection already supported other emulated music types so I'm not sure
how you all would want to work that.  Right now I've artificially constrained
the plugin to only play real SPC files in case a different file type gets
passed to it somehow but I'm not sure how to support multiple types in one
plugin, or if you all would want to go that route anyways.

Patch itself compiles with no warnings on gcc 4.4.1, and is tested using
GST_PLUGIN_PATH to work on Phonon applications and a command-line gstreamer
test application I have.  How do I know GST_PLUGIN_PATH was right?  Remove the
gme_start_track() line and find out for yourself... ;)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=576800.