[gstreamer-bugs] [Bug 576800] gstreamer SPC plugin requires non-portable x86 code

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=576800

  GStreamer | gst-plugins-bad | Ver: git

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139717|none                        |needs-work
               Flag|                            |




------- Comment #9 from Sebastian Dröge  2009-08-02 10:41 UTC -------
I guess instead of #ifdef'ing to work with libgme and openspc the better
solution would be to only work with libgme and at the same time add support for
the other file formats that libgme understands.

Some comments:

* spc->seekpoint = dest / 1000000; // better divide by GST_MSECOND ;)
* On errors in the _play function you should also stop the task and send EOS
downstream additional to GST_ELEMENT_ERROR


Other than that it looks good... change this and I'll commit it :) And
afterwards it'd be great if you could provide an incremental patch to add
support for other file formats than SPC :)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=576800.