[gstreamer-bugs] [Bug 572767] Should error out instead of doing nothing if an OpenGL feature is not present

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=572767

  GStreamer | gst-plugins-gl | Ver: 0.10.x

Julien Isorce changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at circular-chaos.org,
                   |                            |julien.isorce at gmail.com




------- Comment #1 from Julien Isorce  2009-08-04 20:20 UTC -------
Hi,

Those kind of checks (glewinit, framebuffer object OpenGL extension, GLSL
etc..) are made in gstgldisplay.c.
I could make call gst_gl_display_new(gstelement) instead of just
gst_gl_display_new().
Then I would be able to call GST_ELEMENT_ERROR (gstelement, RESOURCE,
NOT_FOUND, ("no framebuffer object OpenGL extension"), (NULL)) inside
gstgldisplay.c.
In this way we do not need to change anything else (no need to return
GST_FLOW_ERROR, see glimagesink)

Note that in a gl flow (for example: glupload ! glfilters ! glimagesink)
the gl element that calls gst_gl_display_new is always the first one.

I think it would be enough for now, at least we could handle most of the basic
checks (because actually they are handle silentely, I mean no messages are
posted to the bus or no signals)

Any comments before I start the changes ?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=572767.